Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify command application #239

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Simplify command application #239

merged 5 commits into from
Aug 7, 2024

Conversation

janhohenheim
Copy link
Member

No description provided.

Copy link
Collaborator

@benfrankel benfrankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes required, but want responses before approving.

src/audio/soundtrack.rs Outdated Show resolved Hide resolved
src/audio/sound_effects.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@benfrankel benfrankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed typo, other than that approved

src/audio/soundtrack.rs Outdated Show resolved Hide resolved
src/audio/soundtrack.rs Outdated Show resolved Hide resolved
@janhohenheim janhohenheim enabled auto-merge (squash) August 7, 2024 21:26
@janhohenheim janhohenheim merged commit bd9d35f into main Aug 7, 2024
4 checks passed
@janhohenheim janhohenheim deleted the simplify-command branch August 7, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants